-
Notifications
You must be signed in to change notification settings - Fork 267
Experimental: Native CSV files read #3044
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
# Conflicts: # native/core/src/execution/planner.rs # native/proto/src/proto/operator.proto # spark/src/main/scala/org/apache/comet/rules/CometExecRule.scala
This reverts commit 768b3e9.
|
nice, would love to see benches ) |
|
Shouldn't CSV be a file format and part of |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #3044 +/- ##
============================================
+ Coverage 56.12% 59.64% +3.51%
- Complexity 976 1381 +405
============================================
Files 119 169 +50
Lines 11743 15618 +3875
Branches 2251 2592 +341
============================================
+ Hits 6591 9315 +2724
- Misses 4012 4995 +983
- Partials 1140 1308 +168 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Thanks @parthchandra, you are absolutely right. In the first phase, I wanted to implement it only for DataSourceV2 to check the performance improvement. I hope to finish the benchmark tests in the coming days. |
Which issue does this PR close?
Rationale for this change
Added an experimental implementation of native CSV file reading (currently only for DataSourceV2 version)
Required improvements:
Results of simple benchmark test (1 iteration): native_csv_read.txt
How are these changes tested?