fix: Convert Spark columnar batches to Arrow in CometNativeWriteExec … #3075
+148
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shekharrajak
force-pushed
the
fix/issue-2944-local-writer-arrow-array
branch
from
5a6966b to
37e4a23
Compare
Contributor
|
Should this just be a modification to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2944
This happens because
RangeExec(and other non-Comet Spark operators) produce Spark'sOnHeapColumnVectorinstead of Arrow arrays that the native writer expects.What changes are included in this PR?
CometNativeWriteExec.doExecuteColumnar()to detect when the child operator is not aCometPlanCometArrowConverters.columnarBatchToArrowBatchIter()CometArrowConverters.rowToArrowBatchIter()How are these changes tested?
Added two new tests in
CometParquetWriterSuite: