Skip to content

Conversation

@andygrove
Copy link
Member

@andygrove andygrove commented Jan 13, 2026

Which issue does this PR close?

N/A

Rationale for this change

Step 1 of N to start cleaning up some of the JVM shuffle code to make it easier to add unit tests

What changes are included in this PR?

  • Move SpillSorter to top-level class
  • Add basic unit tests
  • Fix minor bugs (missing synchronization / no checksum calculated for final partition)

How are these changes tested?

@andygrove andygrove changed the title chore: Refactor JVM shuffle #1 chore: Refactor JVM shuffle: Move SpillSorter to top level class and add tests Jan 13, 2026
@codecov-commenter
Copy link

codecov-commenter commented Jan 13, 2026

Codecov Report

❌ Patch coverage is 91.45299% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 59.84%. Comparing base (f09f8af) to head (4c9c401).
⚠️ Report is 845 commits behind head on main.

Files with missing lines Patch % Lines
...ava/org/apache/spark/shuffle/sort/SpillSorter.java 91.15% 4 Missing and 6 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #3081      +/-   ##
============================================
+ Coverage     56.12%   59.84%   +3.72%     
- Complexity      976     1414     +438     
============================================
  Files           119      168      +49     
  Lines         11743    15571    +3828     
  Branches       2251     2583     +332     
============================================
+ Hits           6591     9319    +2728     
- Misses         4012     4944     +932     
- Partials       1140     1308     +168     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants