-
Notifications
You must be signed in to change notification settings - Fork 1.9k
WIP: Upgrade DataFusion to arrow-rs/parquet 58.0.0 #19728
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
| # We expect something like 0.00 secs with query ? | ||
| query T | ||
| SELECT make_interval(0, 0, 0, 0, 0, 0, 0.0) || ''; | ||
| ---- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is due to @Jefffrey 's improvement in
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
close #17455
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably should remove the accompanying comments too, these
# Intervals being rendered as empty string, see issue:
# https://github.com/apache/datafusion/issues/17455
# We expect something like 0.00 secs with query ?
| | alltypes_plain.parquet | 1851 | 8882 | 2 | page_index=false | | ||
| | alltypes_tiny_pages.parquet | 454233 | 269266 | 2 | page_index=true | | ||
| | lz4_raw_compressed_larger.parquet | 380836 | 1347 | 2 | page_index=false | | ||
| | alltypes_tiny_pages.parquet | 454233 | 269074 | 2 | page_index=true | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this reduction in metadata size is a direct consequence of @WaterWhisperer's PR to improve PageEncoding representation
|
Run benchmarks |
|
🤖 |
|
🤖: Benchmark completed Details
|
|
run benchmarks |
|
run benchmark tpch |
|
🤖 |
|
🤖: Benchmark completed Details
|
|
🤖 |
|
🤖: Benchmark completed Details
|
Which issue does this PR close?
58.0.0(January 2026) arrow-rs#8466Rationale for this change
Keep datafusion up to date (and test Arrow using DataFusion tests)
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?