Reapply "Fix/support duplicate column names" #21260
Draft
alamb wants to merge 3 commits intoapache:mainfrom
Draft
Reapply "Fix/support duplicate column names" #21260alamb wants to merge 3 commits intoapache:mainfrom
alamb wants to merge 3 commits intoapache:mainfrom
Conversation
Contributor
Author
|
I tried to update the sqllogictests following the instructions However, it seems as if our patched version of sqlogictest doesn't match the version that we currently use: I am going to turn codex loose on this for a bit and see what it comes up with |
Contributor
|
Since this was my original change, I'd like to help get it re-landed. I can look into the sqllogictest version mismatch and update the expected results if that would be helpful. |
Contributor
Author
That would be super helpful -- I haven't had a chance to look into it more yet |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft until I have updated the datafusion-testing repo
Which issue does this PR close?
Rationale for this change
I think it is an important feature so let's get it in
What changes are included in this PR?
Are these changes tested?
Yes by CI (and @mbutrovich has updated the tests to run extended tests here #21255)
Are there any user-facing changes?