Skip to content

Reapply "Fix/support duplicate column names" #21260

Draft
alamb wants to merge 3 commits intoapache:mainfrom
alamb:alamb/fix_dupe_column_name
Draft

Reapply "Fix/support duplicate column names" #21260
alamb wants to merge 3 commits intoapache:mainfrom
alamb:alamb/fix_dupe_column_name

Conversation

@alamb
Copy link
Copy Markdown
Contributor

@alamb alamb commented Mar 30, 2026

Draft until I have updated the datafusion-testing repo

Which issue does this PR close?

Rationale for this change

I think it is an important feature so let's get it in

What changes are included in this PR?

  1. Reapply the change (revert the revert)
  2. Update the extended tests expected output as described in the readme

Are these changes tested?

Yes by CI (and @mbutrovich has updated the tests to run extended tests here #21255)

Are there any user-facing changes?

@github-actions github-actions bot added sql SQL Planner sqllogictest SQL Logic Tests (.slt) labels Mar 30, 2026
@alamb
Copy link
Copy Markdown
Contributor Author

alamb commented Mar 30, 2026

I tried to update the sqllogictests following the instructions

However, it seems as if our patched version of sqlogictest doesn't match the version that we currently use:

 [[package]]
 name = "sqllogictest"
-version = "0.29.1"
-source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "d03b2262a244037b0b510edbd25a8e6c9fb8d73ee0237fc6cc95a54c16f94a82"
+version = "0.27.2"
+source = "git+https://github.com/Omega359/sqllogictest-rs.git?rev=73c47cf7#73c47cf74944064173f6b603cb39c3802b46b0c7"
 dependencies = [
  "async-trait",
  "educe",

I am going to turn codex loose on this for a bit and see what it comes up with

@RafaelHerrero
Copy link
Copy Markdown
Contributor

Since this was my original change, I'd like to help get it re-landed. I can look into the sqllogictest version mismatch and update the expected results if that would be helpful.

@alamb
Copy link
Copy Markdown
Contributor Author

alamb commented Mar 30, 2026

Since this was my original change, I'd like to help get it re-landed. I can look into the sqllogictest version mismatch and update the expected results if that would be helpful.

That would be super helpful -- I haven't had a chance to look into it more yet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

sql SQL Planner sqllogictest SQL Logic Tests (.slt)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support columns having the same alias

2 participants