Optimize arrays_zip for perfectly aligned arrays#22245
Open
BipashaBi wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
arrays_zipcurrently reconstructs output arrays row-by-row usingMutableArrayDataeven when all input arrays are perfectly aligned and require no null padding.In the perfectly aligned case, the output can reuse the existing child arrays and offsets directly, avoiding unnecessary copying and allocations.
What changes are included in this PR?
is_perfect_zip()validation helpertry_fast_path()zero-copy execution pathAre these changes tested?
cargo checkcargo test --package datafusion-functions-nestedAre there any user-facing changes?
No user-facing changes. This is an internal performance optimization for
arrays_zip.