Skip to content

fix date_trunc overflows converting extreme non-ns timestamps to nanoseconds #22262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xudong963 merged 1 commit into from
May 17, 2026
+13 −1
Merged

fix date_trunc overflows converting extreme non-ns timestamps to nanoseconds #22262

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion datafusion/functions/src/datetime/date_trunc.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -718,7 +718,13 @@ fn general_date_trunc(
};

// convert to nanoseconds
let nano = date_trunc_coarse(granularity, scale * value, tz)?;
let nano = date_trunc_coarse(
granularity,
value
.checked_mul(scale)
.ok_or_else(|| exec_datafusion_err!("Timestamp {value} out of range"))?,
tz,
)?;

let result = match tu {
Second => match granularity {
Expand Down
6 changes: 6 additions & 0 deletions datafusion/sqllogictest/test_files/datetime/timestamps.slt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2428,6 +2428,12 @@ SELECT arrow_typeof(date_trunc('hour', TIME '14:30:45'));
----
Time64(ns)

query error DataFusion error: Execution error: Timestamp 9223372036854775807 out of range
SELECT date_trunc(
'hour',
arrow_cast(9223372036854775807, 'Timestamp(Second, None)')
);

# Error for granularities not valid for Time types
query error date_trunc does not support 'day' granularity for Time types
SELECT date_trunc('day', TIME '14:30:45');
Expand Down
Loading