Cleanup names phase 6 #691
Merged
+1,194
−986
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conform to a model where the sketch name appears in at least the public class names. For example, the /quantiles/DoublesUnion is renamed to /quantiles/QuantilesDoublesUnion, etc. This is also now consistent with the class naming in C++. In doing this I discovered that Java 25 now issues a Javadoc warnings if a class uses the default (hidden), no arguments constructor because it has no comment. So I added explicit no argument constructors everywhere this occurred across the library. Other than that this commit does not change any code logic. All tests run and pass.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
src/test/java/org/apache/datasketches/quantiles/DoublesMiscTest.java
Dismissed
Show dismissed
Hide dismissed
AlexanderSaydakov
approved these changes
Nov 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit changes the names of mostly the /quantiles/ classes to conform to a model where the sketch name appears in at least the public class names. For example, the /quantiles/DoublesUnion is renamed to /quantiles/QuantilesDoublesUnion, etc. This is also now generally consistent with most of the other sketches in this library as well as the class naming in C++.
In doing this I discovered that Java 25 now issues a Javadoc warnings if a class uses the default (hidden), no arguments constructor because it has no comment. So I added explicit no argument constructors, with a simple comment, everywhere this occurred across the library.
Other than that, this commit does not change any code logic.
All tests run and pass.