[Fix-17979][DAO] Fix INT/BIGINT mismatch of workflow_definition_code in t_ds_serial_command.#17988
Conversation
|
Hi, Thanks, |
|
@iampratap7997-dot Please do not create multiple pull requests for the same issue next time. |
| ALTER COLUMN id SET DEFAULT nextval('t_ds_task_instance_context_id_seq'::regclass); | ||
|
|
||
| -- Change column type to BIGint | ||
| ALTER TABLE t_ds_serial_command |
There was a problem hiding this comment.
We don't need to add ddl at postgresql, since the ddl is correct at 3.4.0.
Understood. I’ll avoid creating multiple PRs for the same issue next time. |
|
Please delete the new added file. |
dolphinscheduler-dao/src/main/resources/sql/upgrade/3.4.1_schema/mysql/dolphinscheduler_ddl.sql
Show resolved
Hide resolved
Done. |
|
@iampratap7997-dot The file still exist, you can use |
...cheduler-dao/src/main/resources/sql/upgrade/3.4.1_schema/postgresql/dolphinscheduler_ddl.sql
Show resolved
Hide resolved
iampratap7997-dot
force-pushed
the
fix/column-mismatch
branch
from
3fb4f2c to
ee4ad97
Compare
ruanwenjun
force-pushed
the
fix/column-mismatch
branch
from
8183a71 to
9ba0683
Compare
|
3 participants
Purpose of the pull request
This PR fixes a data type mismatch between the MySQL schema and Java entity mapping for
t_ds_serial_command.The column
workflow_definition_codewas defined asINT(11)in the 3.4.0 MySQL schema, while the corresponding Java field usesLong. This may cause data truncation errors when values exceed the range ofINT.close #17979
Brief change log
workflow_definition_codefromINT(11)toBIGINT(20)in3.4.0_schema/mysql3.4.1_schema/mysqlto modify the existing column toBIGINT(20)workflowInstanceIdJava type fromIntegertoLongto match existing DB definition (BIGINT(20))Verify this pull request
This change is covered by existing tests.
Additionally:
INT(11)definition forworkflow_definition_codePull Request Notice
Pull Request Notice
Fixes #17979