[Improvement-17843][Master] Add IT case for task timeout alert#18001
[Improvement-17843][Master] Add IT case for task timeout alert#18001shrihari7396 wants to merge 7 commits intoapache:devfrom
Conversation
|
Thanks for opening this pull request! Please check out our contributing guidelines. (https://github.com/apache/dolphinscheduler/blob/dev/docs/docs/en/contribute/join/pull-request.md) |
| // This test intentionally leaves the workflow running, so we skip the resource cleanup check. | ||
| // masterContainer.assertAllResourceReleased(); | ||
| } | ||
| @Test |
There was a problem hiding this comment.
Please avoid unnessnary change.
There was a problem hiding this comment.
Thanks for the review. I have reverted the unnecessary changes and updated the PR accordingly.
Please let me know if any further modifications are needed.
2361ef0 to
c6f6ed8
Compare
|
Hi @SbloodyS, Thank you for the review. This is my first contribution to this project, so I really appreciate your guidance. Thanks! |
|
Hi @SbloodyS, The milestone-label-check is currently failing because no milestone and valid label are assigned to this PR. Could you please help assign the appropriate milestone and label so the check can pass? Thank you! |
Milestones are required before the merger, and contributors do not need to pay attention to them. You should check failed IT. It did not passed. |
|
Hi @SbloodyS, I would like to work on adding the integration test case for task timeout alert in the master module. While preparing the environment, my IDE formatter modified some files unintentionally. I will revert any unrelated formatting changes and ensure only the relevant test case changes are included in the PR. I will first analyze the current timeout handling and alert triggering flow to ensure the IT covers the correct execution path (timeout detection → task state update → alert creation). Please let me know if there are any specific scenarios or timeout strategies (e.g., WARN vs FAILED) that you would like the test to cover. Thanks! |
|
Hi @SbloodyS, I have applied spotless formatting and updated the PR accordingly. Thanks. |
shrihari7396
left a comment
There was a problem hiding this comment.
Thanks for the review. I have reverted the unnecessary changes and updated the PR accordingly.
I also ensured the formatting issues are fixed.
Please let me know if any further modifications are needed.
| // This test intentionally leaves the workflow running, so we skip the resource cleanup check. | ||
| // masterContainer.assertAllResourceReleased(); | ||
| } | ||
| @Test |
There was a problem hiding this comment.
Thanks for the review. I have reverted the unnecessary changes and updated the PR accordingly.
Please let me know if any further modifications are needed.
Closes #17843