Fix axisLabel.height not taking effect without backgroundColor#21531
Fix axisLabel.height not taking effect without backgroundColor#2153104cb wants to merge 1 commit intoapache:masterfrom
Conversation
The height property was being set on text style but had no visual effect without a backgroundColor because zrender only uses height for background box rendering. Fix: Enable box properties processing when height is explicitly set, so that zrender can properly render the box with the specified height.
|
Thanks for your contribution! Please DO NOT commit the files in dist, i18n, and ssr/client/dist folders in a non-release pull request. These folders are for release use only. To reviewers: If this PR is going to be described in the changelog in the future release, please make sure this PR has one of the following labels: This message is shown because the PR description doesn't contain the document related template. |
Ovilia
left a comment
Ovilia
left a comment
There was a problem hiding this comment.
As suggested in #21504, I believe the current performance is, to a certain extent, by-design. Therefore, this issue might not need to be fixed. Moreover, making a fix could potentially have an impact on compatibility. Hence, I suggest closing this pull request.
2 participants
Fixes #21504. The height property was being set on text style but had no visual effect without a backgroundColor because zrender only uses height for background box rendering. This fix enables box properties processing when height is explicitly set, so that zrender can properly render the box with the specified height.