[FLINK-38899][runtime-web] Introduce the Rescales/History sub-page for streaming jobs with the adaptive scheduler enabled#27874
[FLINK-38899][runtime-web] Introduce the Rescales/History sub-page for streaming jobs with the adaptive scheduler enabled#27874och5351 wants to merge 4 commits intoapache:masterfrom
Conversation
RocMarshal
left a comment
There was a problem hiding this comment.
Hi, @och5351 Thank you for your hard work.
LGTM on the whole, just a few of comments.
PTAL in your free time :)
flink-runtime-web/web-dashboard/src/app/interfaces/job-rescales.ts
Outdated
Show resolved
Hide resolved
flink-runtime-web/web-dashboard/src/app/interfaces/job-rescales.ts
Outdated
Show resolved
Hide resolved
flink-runtime-web/web-dashboard/src/app/interfaces/job-rescales.ts
Outdated
Show resolved
Hide resolved
flink-runtime-web/web-dashboard/src/app/interfaces/job-rescales.ts
Outdated
Show resolved
Hide resolved
flink-runtime-web/web-dashboard/src/app/pages/job/rescales/job-rescales.component.html
Show resolved
Hide resolved
flink-runtime-web/web-dashboard/src/app/pages/job/rescales/job-rescales.component.html
Outdated
Show resolved
Hide resolved
flink-runtime-web/web-dashboard/src/app/interfaces/job-rescales.ts
Outdated
Show resolved
Hide resolved
|
Hi, @RocMarshal ! Thank you. |
flink-runtime-web/web-dashboard/src/app/interfaces/job-rescales.ts
Outdated
Show resolved
Hide resolved
…r streaming jobs with the adaptive scheduler enabled
…r streaming jobs with the adaptive scheduler enabled - Temporary commit for review (Changed the `expand` and `styles` in the job-rescales.component.html.)
|
I checked UI of the PR locally with #27705. checked:
LGTM +1 on the whole just a few of issues:
Thanks @och5351 for the hard work. |
…r streaming jobs with the adaptive scheduler enabled - Temporary commit for review (Changed the display method when the variable is empty)
Hi, @RocMarshal ! Could you please review this again? While waiting
Done
|
Thanks @och5351 for the quick updated.
That's a good catch, reasonable! |
…r streaming jobs with the adaptive scheduler enabled - Temporary commit for review (Changed the refresh function)
RocMarshal
left a comment
There was a problem hiding this comment.
Thanks @och5351 for the update
I'll merge it after the REST API related PRs ready and no more comments from other reviewers.






What is the purpose of the change
Brief change log
Adds the 'Rescales/History' tab and 'HistoryDetail' subpage in relation to [FLINK-38897][Runtime/REST] Introduce /jobs/:jobid/rescales/config endpoint to REST API #27580.
Rescales History Tab
Rescales HistoryDetail page
Verifying this change
Does this pull request potentially affect one of the following parts:
@Public(Evolving): (yes / no)Documentation