Skip to content

[FLINK-39388][tests] Fix flaky DataGeneratorSourceITCase#testGatedRateLimiter #27883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
featzhang wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[FLINK-39388][tests] Fix flaky DataGeneratorSourceITCase#testGatedRateLimiter #27883

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 26 additions & 4 deletions ...st/src/test/java/org/apache/flink/connector/datagen/source/DataGeneratorSourceITCase.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
import org.apache.flink.api.common.ExecutionConfig;
import org.apache.flink.api.common.eventtime.WatermarkStrategy;
import org.apache.flink.api.common.functions.FlatMapFunction;
import org.apache.flink.api.common.state.CheckpointListener;
import org.apache.flink.api.common.typeinfo.BasicTypeInfo;
import org.apache.flink.api.common.typeinfo.TypeInformation;
import org.apache.flink.api.common.typeinfo.Types;
Expand Down Expand Up @@ -254,21 +255,42 @@ public TypeInformation getTypeInformation() {
}
}

/**
* A filter that only passes through elements received before the first checkpoint completes.
*
* <p>The filter stops collecting elements in {@link #notifyCheckpointComplete(long)} rather
* than in {@link #snapshotState(FunctionSnapshotContext)}, to avoid a race condition where the
* checkpoint barrier arrives at this operator before all upstream elements (emitted in the same
* checkpoint cycle) have been processed. Using {@code notifyCheckpointComplete} ensures that
* the checkpoint has fully propagated through the pipeline before we stop collecting.
*/
private static class FirstCheckpointFilter
implements FlatMapFunction<Long, Long>, CheckpointedFunction {
implements FlatMapFunction<Long, Long>, CheckpointedFunction, CheckpointListener {

private volatile boolean firstCheckpoint = true;
private volatile boolean firstCheckpointCompleted = false;
private long firstCheckpointId = Long.MIN_VALUE;

@Override
public void flatMap(Long value, Collector<Long> out) throws Exception {
if (firstCheckpoint) {
if (!firstCheckpointCompleted) {
out.collect(value);
}
}

@Override
public void snapshotState(FunctionSnapshotContext context) throws Exception {
firstCheckpoint = false;
// Record the ID of the first checkpoint so we can stop collecting when it completes.
if (firstCheckpointId == Long.MIN_VALUE) {
firstCheckpointId = context.getCheckpointId();
}
}

@Override
public void notifyCheckpointComplete(long checkpointId) throws Exception {
// Stop collecting elements once the first checkpoint has completed.
if (checkpointId >= firstCheckpointId && firstCheckpointId != Long.MIN_VALUE) {
firstCheckpointCompleted = true;
}
}

@Override
Expand Down