Introduce CompactedRowEncoder #161
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@luoyuxia @AndreaBozzo Appreciate review here |
AndreaBozzo
approved these changes
Jan 14, 2026
Contributor
AndreaBozzo
left a comment
AndreaBozzo
left a comment
There was a problem hiding this comment.
LGTM
just added a very minor doc note
AndreaBozzo
approved these changes
Jan 14, 2026
Contributor
fresh-borzoni
left a comment
fresh-borzoni
left a comment
There was a problem hiding this comment.
@leekeiabstraction Thank you for the PR!
Left some comments. PTAL.
leekeiabstraction
force-pushed
the
compacted-row-encoder
branch
from
06c4962 to
f5a6864
Compare
# Conflicts: # crates/fluss/src/row/compacted/compacted_row_writer.rs # Conflicts: # crates/fluss/src/metadata/datatype.rs
leekeiabstraction
force-pushed
the
compacted-row-encoder
branch
from
f5a6864 to
a3ea206
Compare
Contributor
Author
|
@fresh-borzoni Addressed/answered your comments. PTAL |
luoyuxia
approved these changes
Jan 15, 2026
Contributor
luoyuxia
left a comment
luoyuxia
left a comment
There was a problem hiding this comment.
@leekeiabstraction Thanks. LGTM!
fresh-borzoni
approved these changes
Jan 15, 2026
Contributor
fresh-borzoni
left a comment
fresh-borzoni
left a comment
There was a problem hiding this comment.
LGTM, thank you for the nice code!
Contributor
|
Look werid.. The ci stuck... |
Contributor
Github runners are experiencing heavy loads right now, happening in my other repos |
Contributor
Seems now many developers are online.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: close #160
Testing
Existing tests for CompactedRow passes
Subsequent PR for #113 will introduce UpsertWriter and its test cases that will cover the code path of CompactedRowEncoder