[spark] Add Spark show/add/drop partition support #2314
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
wuchong
reviewed
Jan 11, 2026
fluss-spark/fluss-spark-ut/src/test/scala/org/apache/fluss/spark/SparkDDLPartitionTest.scala
Outdated
Show resolved
Hide resolved
fluss-spark/fluss-spark-ut/src/test/scala/org/apache/fluss/spark/SparkDDLPartitionTest.scala
Outdated
Show resolved
Hide resolved
Yohahaha
force-pushed
the
spark-partition
branch
from
bb1f92d to
0682813
Compare
Contributor
Author
|
YannByron
reviewed
Jan 12, 2026
...-common/src/main/scala/org/apache/fluss/spark/catalog/SupportsFlussPartitionManagement.scala
Show resolved
Hide resolved
YannByron
reviewed
Jan 12, 2026
| private def toInternalRow( | ||
| partitionSpec: PartitionSpec, | ||
| partitionSchema: StructType): InternalRow = { | ||
| val row = new SpecificInternalRow(partitionSchema) |
Contributor
There was a problem hiding this comment.
Let's keep it here temporarily. I will move this to other place in to support batch read PR later.
YannByron
reviewed
Jan 12, 2026
fluss-spark/fluss-spark-ut/src/test/scala/org/apache/fluss/spark/SparkCatalogTest.scala
Outdated
Show resolved
Hide resolved
YannByron
reviewed
Jan 12, 2026
| sql(s"INSERT INTO t values(1, 'a', 'a', 1), (2, 'b', 'a', 2), (3, 'c', 'c', 3)") | ||
|
|
||
| var expect = Seq(Row("pt1=a/pt2=1"), Row("pt1=a/pt2=2"), Row("pt1=c/pt2=3")) | ||
| checkAnswer(sql(s"SHOW PARTITIONS t"), expect) |
Contributor
There was a problem hiding this comment.
checkAnswer(sql(s"SHOW PARTITIONS t"), Row("pt1=a/pt2=1") :: Row("pt1=a/pt2=2") :: Row("pt1=c/pt2=3") :: Nil)
YannByron
reviewed
Jan 12, 2026
fluss-spark/fluss-spark-ut/src/test/scala/org/apache/fluss/spark/SparkCatalogTest.scala
Show resolved
Hide resolved
YannByron
reviewed
Jan 12, 2026
fluss-spark/fluss-spark-ut/src/test/scala/org/apache/fluss/spark/SparkCatalogTest.scala
Show resolved
Hide resolved
Yohahaha
force-pushed
the
spark-partition
branch
from
0682813 to
968af43
Compare
Contributor
|
LGTM. |
Contributor
Author
|
kindly ping @wuchong |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
As title.
Linked issue: close #xxx
Brief change log
Tests
org.apache.fluss.spark.SparkCatalogTest
API and Format
Documentation