[spark] Add spark streaming write support #2357
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
YannByron
reviewed
Jan 14, 2026
|
|
||
| /** An interface that extends from Spark [[StreamingWrite]]. */ | ||
| trait FlussStreamingWrite extends StreamingWrite with Serializable { | ||
| override def useCommitCoordinator(): Boolean = false |
Contributor
There was a problem hiding this comment.
Why we have to disable to use commit coordinator?
Contributor
Author
There was a problem hiding this comment.
Kafka streaming write disabled too, batch writer disabled too.
will reenable when needed.
YannByron
reviewed
Jan 14, 2026
|
|
||
| val result = rowsWithType.zip(expectInput).forall { | ||
| case (flussRowWithType, expect) => | ||
| flussRowWithType._1.equals(expect._1) && flussRowWithType._2.getLong( |
Contributor
There was a problem hiding this comment.
Can we use Assertions.assertThat to check the result, and then we don't have to print the mismatch data.
Contributor
Author
There was a problem hiding this comment.
Just follow spark ut to print whole data when mismatched
YannByron
reviewed
Jan 14, 2026
fluss-spark/fluss-spark-ut/src/test/scala/org/apache/fluss/spark/SparkStreamingTest.scala
Outdated
Show resolved
Hide resolved
Contributor
Author
|
more comments? @YannByron cc @wuchong |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
As title.
Linked issue: close #xxx
Brief change log
Tests
org.apache.fluss.spark.SparkStreamingTest
API and Format
Documentation