Skip to content

Conversation

@luoyuxia
Copy link
Contributor

@luoyuxia luoyuxia commented Jan 13, 2026

…ruct

Purpose

Linked issue: close #2281

Brief change log

Extract the core logic of parse arguments & build tiering job to FlussLakeTiering, the external implement can overwrite FlussLakeTiering.

Some thing like

public class FlussAliLakeTieringEntrypoint {

    public static void main(String[] args) throws Exception {
        return new FlussAliLakeTiering()
    }
}

public class FlussAliLakeTiering extends FlussLakeTiering{
 // todo
}

Tests

API and Format

Documentation

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request refactors the FlussLakeTiering entrypoint to improve extensibility by extracting the core job construction logic into a separate pluggable class. This enables developers to customize the tiering job construction (e.g., for security token injection) without modifying the main entrypoint.

Changes:

  • Extracted tiering job logic from FlussLakeTieringEntrypoint into a new FlussLakeTiering class with protected fields and methods for extensibility
  • Simplified FlussLakeTieringEntrypoint to delegate to FlussLakeTiering
  • Updated README documentation to describe the new architecture

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
FlussLakeTieringEntrypoint.java Refactored to delegate all logic to the new FlussLakeTiering class
FlussLakeTiering.java New class containing the extracted configuration parsing and job execution logic with protected members for extensibility
README.md Updated documentation to describe the two-class architecture

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@luoyuxia luoyuxia force-pushed the make-fluss-lake-tiering-entry-point-pluggable branch from 23c84eb to efcc2f9 Compare January 14, 2026 02:02
@luoyuxia luoyuxia requested a review from wuchong January 14, 2026 02:34
@luoyuxia luoyuxia marked this pull request as draft January 14, 2026 05:47
@luoyuxia luoyuxia removed the request for review from wuchong January 14, 2026 05:48
@luoyuxia luoyuxia marked this pull request as ready for review January 14, 2026 12:34
@luoyuxia luoyuxia requested a review from wuchong January 14, 2026 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make FlussLakeTieringEntrypoint pluggable

1 participant