[hotfix] Fix union read fail when from timestamp and projection enabled #2383
+22
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luoyuxia
commented
Jan 15, 2026
| } else { | ||
| Map<Integer, List<LakeSplit>> nonPartitionLakeSplits = | ||
| lakeSplits.values().iterator().next(); | ||
| lakeSplits.isEmpty() ? null : lakeSplits.values().iterator().next(); |
Contributor
Author
There was a problem hiding this comment.
when no split is generate, it may be empty. Let's use the safe way.
| // we will have three additional system columns, __bucket, __offset, __timestamp | ||
| // in lake, get the __timestamp index in lake table | ||
| final int timestampFieldIndex = flussRowType.getFieldCount() + 2; | ||
| final int timestampFieldIndex = tableOutputType.getFieldCount() + 2; |
Contributor
Author
There was a problem hiding this comment.
flussRowType is projected row, we should use origin tableOutputType
| } | ||
| }); | ||
|
|
||
| if (pendingHybridLakeFlussSplits != null) { |
Contributor
Author
There was a problem hiding this comment.
move out from the loop to speed it.
Contributor
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: close #xxx
Fix when union read from lake table, and projectinn is enabled, the
__timestampin paimon will not match which cause cast exceptionBrief change log
Use table origin row type instead of projected row type.
Tests
Adjust the test to use enable projection
API and Format
Documentation