[test] fix flaky testRebalanceWithRemoteLog#3409
Open
wattt3 wants to merge 1 commit into
Open
Conversation
Author
|
Hi @swuferhong / @wuchong |
swuferhong
approved these changes
Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: close #3385
The test captures the remote log segment count, then asserts it's unchanged after rebalance.
But,
produceRecordsAndWaitRemoteLogCopy()does not ensure that all log segments have been copied to remote, so theremoteLogSize(captured count) is non-deterministic.Brief change log
FlussClusterExtension#waitUntilAllLogSegmentsCopyToRemote(), which waits until the remote log end offset reaches the active segment's base offset (i.e. all non-active segments are copied to remote).waitUntilAllLogSegmentsCopyToRemote()instead ofwaitUntilSomeLogSegmentsCopyToRemote(), so the captured segment count is stable.Tests
Ran
RebalanceManagerITCase.testRebalanceWithRemoteLog100 times