Conversation
java/fory-core/src/main/java/org/apache/fory/serializer/ArraySerializers.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Shawn Yang <chaokunyang@apache.org>
...re/src/main/resources/META-INF/native-image/org.apache.fory/fory-core/reflection-config.json
Outdated
Show resolved
Hide resolved
...src/main/resources/META-INF/native-image/org.apache.fory/fory-core/serialization-config.json
Outdated
Show resolved
Hide resolved
...re/src/main/resources/META-INF/native-image/org.apache.fory/fory-core/reflection-config.json
Outdated
Show resolved
Hide resolved
| public static final int EXT_UINT64 = 23; | ||
| public static final int EXT_VAR_UINT64 = 24; | ||
| public static final int STRING = 25; | ||
| public static final int FLOAT16 = 12; |
There was a problem hiding this comment.
This ID is wrong, here is current id def in main branch:
/** float8: an 8-bit floating point number. */
public static final int FLOAT8 = 16;
/** float16: a 16-bit floating point number. */
public static final int FLOAT16 = 17;
/** bfloat16: a 16-bit brain floating point number. */
public static final int BFLOAT16 = 18;
Same for Float16 array
| "allPublicConstructors": true, | ||
| "allDeclaredMethods": true, | ||
| "allPublicMethods": true | ||
| }, |
There was a problem hiding this comment.
This is syntax error, please fix it
|
|
||
| @Data | ||
| @AllArgsConstructor | ||
| class StructWithSpecialValues { |
There was a problem hiding this comment.
Please also create another tests to struct with Float16List as fields and also test Float16List as top level objects for serialization
| public static final int EXT_VAR_UINT32 = 23; | ||
| public static final int EXT_UINT64 = 24; | ||
| public static final int EXT_VAR_UINT64 = 25; | ||
| public static final int STRING = 26; |
There was a problem hiding this comment.
java/fory-core/src/main/java/org/apache/fory/serializer/FieldGroups.java also needs update to clarify Float16 as build-in fields and grouped into primitive/boxed groups based whethther it's nullable.
java/fory-core/src/main/java/org/apache/fory/builder/BaseObjectCodecBuilder.java also needs update to handle Flaot16 specially, you can start from serializePrimitiveField
java/fory-core/src/main/java/org/apache/fory/serializer/AbstractObjectSerializer.java may also needs updates
2 participants
Why?
What does this PR do?
Related issues
Close #3205
Does this PR introduce any user-facing change?
Benchmark