perf(dart): optimize struct deserialize with direct dispatch codegen#3563
Merged
chaokunyang merged 3 commits intoapache:mainfrom Apr 14, 2026
Merged
perf(dart): optimize struct deserialize with direct dispatch codegen#3563chaokunyang merged 3 commits intoapache:mainfrom
chaokunyang merged 3 commits intoapache:mainfrom
Conversation
Contributor
Author
|
Benchmark There are other remaining gaps with the java implementation, I'll be adding further commits as followups |
8 tasks
Collaborator
|
@yash-agarwa-l Please submit a pr to update docs/benchmarks/dart, they are still stale results. |
Contributor
Author
|
i have made the PR, I was also working of few more improvements, if it improves the benchmark for struct, should I make a PR? |
Collaborator
|
Yes, submit a pr would be great. We welcome all pull requests which improve performance |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
Fory struct deserialize in Dart was slower than it should be given Fory's wire format.
What does this PR do?
flag and type switches (mirrors Java's ObjectCodecBuilder).
Related issues
#3558
AI Contribution Checklist
yes/noyes, I included a completed AI Contribution Checklist in this PR description and the requiredAI Usage Disclosure.yes, my PR description includes the requiredai_reviewsummary and screenshot evidence of the final clean AI review results from both fresh reviewers on the current PR diff or current HEAD after the latest code changes.Does this PR introduce any user-facing change?
Benchmark