Skip to content

GEODE-10556: Fix SSL handshake failure in PulseSecurityWithSSLTest when JmxManagerBindAddress is empty #7984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JinwooHwang wants to merge 1 commit into
base: develop
Choose a base branch
from
+8 −1
Open

GEODE-10556: Fix SSL handshake failure in PulseSecurityWithSSLTest when JmxManagerBindAddress is empty #7984

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion geode-core/src/main/java/org/apache/geode/management/internal/ManagementAgent.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -296,7 +296,14 @@ private void loadWebApplications() {
// we need to pass in the sllConfig to pulse because it needs it to make jmx connection
if (agentUtil.isAnyWarFileAvailable(pulseWar)) {
System.setProperty(PULSE_EMBEDDED_PROP, "true");
System.setProperty(PULSE_HOST_PROP, "" + config.getJmxManagerBindAddress());
// When JmxManagerBindAddress is empty (bind all interfaces), Pulse must connect to
// localhost rather than the empty string. An empty host in the JMX URL resolves to
// InetAddress.getLocalHost(), which on Linux/Docker gives the container's bridge IP
// (e.g. 172.17.0.2) instead of 127.0.0.1. The embedded keystore only contains
// IPAddress:127.0.0.1 as a SAN, so the SSL handshake fails on any non-loopback IP.
String jmxBindAddress = config.getJmxManagerBindAddress();
System.setProperty(PULSE_HOST_PROP,
jmxBindAddress.isEmpty() ? "localhost" : jmxBindAddress);
System.setProperty(PULSE_PORT_PROP, "" + config.getJmxManagerPort());

final SocketCreator jmxSocketCreator =
Expand Down
Loading