HIVE-27190: Implement col stats cache for hive iceberg table#6380
Open
deniskuzZ wants to merge 1 commit intoapache:masterfrom
Open
HIVE-27190: Implement col stats cache for hive iceberg table#6380deniskuzZ wants to merge 1 commit intoapache:masterfrom
deniskuzZ wants to merge 1 commit intoapache:masterfrom
Conversation
|
zhangbutao
reviewed
Apr 6, 2026
| } | ||
| } | ||
|
|
||
| if (hiveColStats != null && hiveColStats.size() == nonPartColNamesThatRqrStats.size()) { |
Contributor
There was a problem hiding this comment.
Why was the null check removed?
| computePartitionList(hiveConf, null, new HashSet<>()); | ||
| } | ||
|
|
||
| String partitionListKey = partitionList.getKey().orElse(null); |
Contributor
There was a problem hiding this comment.
Why was the null key check removed?
| @Override | ||
| public long getSnapshotId(org.apache.hadoop.hive.ql.metadata.Table hmsTable) { | ||
| Table table = IcebergTableUtil.getTable(conf, hmsTable.getTTable()); | ||
| Snapshot snapshot = IcebergTableUtil.getTableSnapshot(table, hmsTable); |
Contributor
There was a problem hiding this comment.
Should we handle the exception case where the table is null?
| key = tab.getFullyQualifiedName() + "." + tab.getMetaTable() + ";"; | ||
| } else if (tab.getSnapshotRef() != null) { | ||
| key = tab.getFullyQualifiedName() + "." + tab.getSnapshotRef() + ";"; | ||
| } else if (tab.isNonNative()) { |
Contributor
There was a problem hiding this comment.
Should we currently limit ourselves to only Iceberg tables, rather than all non-native tables?
| nonPartColNamesThatRqrStats.get(i), | ||
| hiveNonPartitionColsMap.get(nonPartColIndxsThatRqrStats.get(i)).getTypeName())); | ||
| } | ||
| colNamesFailedStats.clear(); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Why are the changes needed?
Does this PR introduce any user-facing change?
How was this patch tested?