fix(metadata): propagate timeline server config from main dataset to metadata #17486
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the issue this Pull Request addresses
This PR fixes a configuration inconsistency where the embedded timeline server configuration from the main dataset was not being propagated to the metadata table. Previously, the metadata table writer was hardcoded to disable the embedded timeline server (
withEmbeddedTimelineServerEnabled(false)), regardless of the main dataset's configuration. This could lead to inconsistent behavior between the main dataset and metadata table.Summary and Changelog
Summary: This fix ensures that the embedded timeline server configuration is properly propagated from the main dataset write config to the metadata table write config.
Changelog:
HoodieMetadataWriteUtils.javato usewriteConfig.isEmbeddedTimelineServerEnabled()instead of hardcodedfalsevalueImpact
This change affects the metadata table's timeline server configuration behavior:
Risk Level
Low - This is a configuration propagation fix that aligns the metadata table behavior with the main dataset. The change is minimal (1 line) and makes the behavior more consistent. The embedded timeline server feature itself is well-tested in the main dataset context.
Documentation Update
None - This is an internal configuration fix with no new configs or user-facing changes. The existing embedded timeline server configuration documentation already applies to both main and metadata tables.
Contributor's checklist