feat(table): make Parquet root schema repetition configurable#896
Draft
cassio-paesleme wants to merge 2 commits intoapache:mainfrom
Draft
feat(table): make Parquet root schema repetition configurable#896cassio-paesleme wants to merge 2 commits intoapache:mainfrom
cassio-paesleme wants to merge 2 commits intoapache:mainfrom
Conversation
Add write.parquet.root-repetition property (required/optional/repeated, default: required) to control the Parquet root schema element's repetition type. arrow-go defaults to Repeated, which Snowflake interprets as one-level list encoding and rejects files with list columns. Defaulting to Required aligns with the Parquet spec and matches arrow-rs, pyarrow, and parquet-java behavior.
Contributor
|
I think this is resolved by apache/arrow-go#723, so it should be fixed when arrow-go cuts a new release & iceberg-go bumps the dependency. |
Member
|
@cassio-paesleme can you confirm that the update to arrow-go and the bump here solved this issue? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
arrow-go defaults the Parquet root schema element repetition to
Repeated. Snowflake (and some other readers) interpretRepeatedat the root as one-level list encoding and reject files that contain list columns. This causes write failures when targeting Snowflake-managed Iceberg tables.Fix
Add a
write.parquet.root-repetitiontable property (values:required/optional/repeated, default:required). The defaultrequiredaligns with the Parquet spec and matches the behaviour of arrow-rs, pyarrow, and parquet-java.The property is applied in
parquetFormat.GetWritePropertiesviaparquet.WithRootRepetition.Why this default is correct
The Parquet spec defines the root message element as a container, not a repeated field. Defaulting to
Requiredis the most interoperable choice and is what every major Parquet writer already does. arrow-go'sRepeateddefault is an outlier.Testing
Existing
./table/...suite passes. The property is exercised end-to-end in the Docker data platform against Snowflake-managed Iceberg tables (docker/data-platform#406).Original implementation by @hcrosse.