Conversation
Contributor
Author
|
Thanks for following up @mnzpk, really appreciate it. I incorporated the tests in this PR as well. Please give it a try and let me know if that fully resolves the issue |
kevinjqliu
force-pushed
the
hive-client-tests
branch
from
e0ca31d to
6dc1378
Compare
Contributor
|
@kevinjqliu can confirm that with this fix I can no longer reproduce the issue. |
kevinjqliu
commented
Apr 21, 2025
tests/catalog/test_hive.py
Outdated
Comment on lines
223
to
226
| except Exception: | ||
| logging.exception( | ||
| "An error occurred while responding to client", | ||
| ) |
Contributor
Author
There was a problem hiding this comment.
Suggested change
| except Exception: | |
| logging.exception( | |
| "An error occurred while responding to client", | |
| ) | |
| except Exception: | |
| pass |
This creates a lot of noise in tests, perhaps we can just skip it since we're not testing for this functionality
Contributor
Author
|
Thanks for confirming @mnzpk |
Fokko
approved these changes
Apr 22, 2025
Contributor
Fokko
left a comment
Fokko
left a comment
There was a problem hiding this comment.
LGTM @kevinjqliu Thanks for adding the tests. Can you resolve the conflicts? This should be fun to cherry-pick to pyiceberg-0.9.x 😀
kevinjqliu
force-pushed
the
hive-client-tests
branch
from
559bc6d to
da0a62a
Compare
Contributor
Author
Fokko
pushed a commit
that referenced
this pull request
Apr 25, 2025
<!--
Thanks for opening a pull request!
-->
<!-- In the case this PR will resolve an issue, please replace
${GITHUB_ISSUE_ID} below with the actual Github issue id. -->
<!-- Closes #${GITHUB_ISSUE_ID} -->
Closes #1744 (second try)
First try (#1747) did not fully resolve the issue. See
#1747 (review)
yes
<!-- In the case of user-facing changes, please add the changelog label.
-->
---------
Co-authored-by: mnzpk <84433140+mnzpk@users.noreply.github.com>
3 tasks
gabeiglio
pushed a commit
to Netflix/iceberg-python
that referenced
this pull request
Aug 13, 2025
<!--
Thanks for opening a pull request!
-->
<!-- In the case this PR will resolve an issue, please replace
${GITHUB_ISSUE_ID} below with the actual Github issue id. -->
<!-- Closes #${GITHUB_ISSUE_ID} -->
Closes apache#1744 (second try)
# Rationale for this change
First try (apache#1747) did not fully resolve the issue. See
apache#1747 (review)
# Are these changes tested?
yes
# Are there any user-facing changes?
<!-- In the case of user-facing changes, please add the changelog label.
-->
---------
Co-authored-by: mnzpk <84433140+mnzpk@users.noreply.github.com>
MoIMC
pushed a commit
to imc-trading/iceberg-python
that referenced
this pull request
Dec 11, 2025
<!--
Thanks for opening a pull request!
-->
<!-- In the case this PR will resolve an issue, please replace
${GITHUB_ISSUE_ID} below with the actual Github issue id. -->
<!-- Closes #${GITHUB_ISSUE_ID} -->
Closes apache#1744 (second try)
First try (apache#1747) did not fully resolve the issue. See
apache#1747 (review)
yes
<!-- In the case of user-facing changes, please add the changelog label.
-->
---------
Co-authored-by: mnzpk <84433140+mnzpk@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1744 (second try)
Rationale for this change
First try (#1747) did not fully resolve the issue. See #1747 (review)
Are these changes tested?
yes
Are there any user-facing changes?