fix: SqlCatalog should use supplied name #1991
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
liurenjie1024
left a comment
liurenjie1024
left a comment
There was a problem hiding this comment.
Thanks @cornerwings for this pr, generally LGTM! Just one minor point to fix.
| .unwrap() | ||
| } | ||
|
|
||
| async fn new_sql_catalog(warehouse_location: String) -> impl Catalog { |
Contributor
There was a problem hiding this comment.
I don't think we should keep this function. We should remove it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
What changes are included in this PR?
Change correctly updates name in catalog config to ensure catalog can correctly find/refer to existing namespaces/objects
Are these changes tested?
Added a new test that verifies name is considered by catalog (test fails without the corresponding code change)