feat(datafusion): Add LIKE predicate pushdown for StartsWith patterns #2014
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement pushdown for LIKE predicates with simple prefix patterns (e.g., 'prefix%') to Iceberg's StartsWith operator. This optimization allows filtering to be performed at the storage layer, significantly improving query performance for prefix searches. Changes: - Add support for Expr::Like in predicate conversion - Convert LIKE 'prefix%' patterns to StartsWith operator - Convert NOT LIKE 'prefix%' patterns to NotStartsWith operator - Handle edge cases: empty prefix, unicode, special characters - Reject complex patterns that cannot be pushed down (wildcards in middle, underscore, ILIKE) - Add 8 comprehensive unit tests covering various scenarios Implementation details: - Only simple prefix patterns ending with % are converted - Patterns with % or _ wildcards in the prefix are not pushed down - Case-insensitive LIKE (ILIKE) is not supported for pushdown - Escape characters are not supported for pushdown - Works seamlessly with other predicates in AND/OR expressions Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement pushdown for LIKE predicates with simple prefix patterns (e.g., 'prefix%') to Iceberg's StartsWith operator. This optimization allows filtering to be performed at the storage layer, significantly improving query performance for prefix searches.
Changes:
Implementation details:
Which issue does this PR close?
What changes are included in this PR?
Are these changes tested?