perf(reader): Fast path ArrowReader::read when concurrency is 1 to avoid waker churn and add determinism to FileScanTask processing #2020
+206
−19
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
What changes are included in this PR?
SessionContext, the tokio runtime, and Spark Tasks, we see frequent waker churn when concurrency is set to 1 in theArrowReader. This adds a fast path that does not usetry_flatten_unorderedand its internalreplace_wakercalls.ORDER BY, so this enables those tests to keep working when concurrency is set to 1.See apache/datafusion-comet#3051 and
Are these changes tested?
New test for determinism, also running the entire Iceberg Java Spark suite via Comet in apache/datafusion-comet#3051.