feat!(runtime): Support custom Runtime in Catalog#2308
Open
CTTY wants to merge 25 commits into
Open
Conversation
CTTY
commented
Apr 13, 2026
| .metadata(metadata) | ||
| .metadata_location(metadata_location) | ||
| .identifier(table_ident) | ||
| .file_io(file_io.clone()) |
Collaborator
Author
There was a problem hiding this comment.
I think we should pass runtime here as well, need to revisit
We can add a builder to IcebergTableProviderFactory and add with_runtime there. But I feel like this can be a separate effort
CTTY
changed the title
blackmwk
reviewed
Apr 29, 2026
blackmwk
reviewed
Apr 30, 2026
| T: Send + 'static, | ||
| { | ||
| JoinHandle(task::spawn_blocking(f)) | ||
| impl Default for Runtime { |
Contributor
There was a problem hiding this comment.
No, we should not implement Default
Collaborator
Author
There was a problem hiding this comment.
I've removed Default. but I also think an infallible function to build a Runtime instance would be convenient.
I've splitted try_from_current into try_current() and current(). The naming matches better with tokio's naming as well.
Please let me know your thoughts!
toutane
added a commit
to DataDog/iceberg-rust
that referenced
this pull request
May 11, 2026
…talog (apache#2308) (#17) * Support custom Runtime in Catalog (cherry picked from commit 131b810) * fix fmt (cherry picked from commit 6e4fe7b) * some improvements (cherry picked from commit 753937b) * separate cpu and io (cherry picked from commit daa4b41) * fix comment (cherry picked from commit 4c3606d) * address conflicts (cherry picked from commit 2ab8d46) * clippy (cherry picked from commit e8e5c41) * address comments (cherry picked from commit 0c88c53) * machete (cherry picked from commit 7d962c6) * convert JoinError to Iceberg Error (cherry picked from commit c786d4d) * remove default and add try_current and current (cherry picked from commit fce392e) * address flakiness in memory catalog test (cherry picked from commit b71cd68) * fmt (cherry picked from commit f3a6a76) * removed owned runtime in RuntimeHandle (cherry picked from commit 6f32270) * minor (cherry picked from commit 9ac62be) --------- Co-authored-by: Shawn Chang <yxchang@amazon.com> Co-authored-by: Shawn Chang <schang@apache.org> Co-authored-by: Shawn Chang <yexiangchang@gmail.com>
blackmwk
reviewed
May 13, 2026
Co-authored-by: blackmwk <liurenjie1024@outlook.com>
Co-authored-by: blackmwk <liurenjie1024@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Runtimesupport enhancement #1958What changes are included in this PR?
with_runtimetoCatalogBuildertraitAre these changes tested?
Yes