feat(partitions): implement StoreConsumerOffset and DeleteConsumerOffset#3071
Open
feat(partitions): implement StoreConsumerOffset and DeleteConsumerOffset#3071
Conversation
Codecov Report❌ Patch coverage is ❌ Your patch check has failed because the patch coverage (0.96%) is below the target coverage (50.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## master #3071 +/- ##
============================================
- Coverage 70.58% 70.24% -0.35%
Complexity 943 943
============================================
Files 1113 1114 +1
Lines 94590 95041 +451
Branches 71787 72259 +472
============================================
- Hits 66770 66763 -7
- Misses 25348 25785 +437
- Partials 2472 2493 +21
🚀 New features to boost your workflow:
|
krishvishal
reviewed
Apr 5, 2026
| Self::parse_staged_consumer_offset_commit(header.operation, &message)?; | ||
| let write_lock = self | ||
| .get_by_ns(namespace) | ||
| .expect("store_consumer_offset: partition not found for namespace") |
Contributor
There was a problem hiding this comment.
Return IggyError instead of using expect.
krishvishal
reviewed
Apr 5, 2026
| ); | ||
| let _ = guard.remove(&key); | ||
| } | ||
| _ => {} |
Contributor
There was a problem hiding this comment.
Instead of silent catch-all. Make it unreachable!.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement
StoreConsumerOffsetandDeleteConsumerOffsetas replicated operations on partition.