Skip to content

IGNITE-28049 Fix DurableBackgroundTasksProcessorSelfTest#testConvertAfterRestoreIfNeeded #12848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zstan merged 6 commits into from
Mar 6, 2026
+6 −2
Merged

IGNITE-28049 Fix DurableBackgroundTasksProcessorSelfTest#testConvertAfterRestoreIfNeeded #12848

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
888e24e
IGNITE-28049 Fix DurableBackgroundTasksProcessorSelfTest#testConvertA…
chesnokoff Mar 3, 2026
1204f8a
Merge branch 'master' into ignite-28049
chesnokoff Mar 6, 2026
254934c
IGNITE-280049 Replace equals with ==
chesnokoff Mar 6, 2026
7698b96
IGNITE-28049 Fix assertion for number of tasks
chesnokoff Mar 6, 2026
5196c37
IGNITE-28049 Decrease wait timeout to 5
chesnokoff Mar 6, 2026
56a0b9a
IGNITE-28049 Update timeout
chesnokoff Mar 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions .../apache/ignite/internal/processors/localtask/DurableBackgroundTasksProcessorSelfTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@
import static org.apache.ignite.testframework.GridTestUtils.assertThrows;
import static org.apache.ignite.testframework.GridTestUtils.getFieldValue;
import static org.apache.ignite.testframework.GridTestUtils.runAsync;
import static org.apache.ignite.testframework.GridTestUtils.waitForCondition;

/**
* Class for testing the {@link DurableBackgroundTasksProcessor}.
Expand Down Expand Up @@ -345,7 +346,10 @@ public void testConvertAfterRestoreIfNeeded() throws Exception {

n = startGrid(0);

assertEquals(3, tasks(n).size());
int tasks = tasks(n).size();
Copy link
Contributor Author

@chesnokoff chesnokoff Mar 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alex-plekhanov Thanks for notion about new fail in this test, it was not reproduced by my local machine and on tc. It can be reproduced if we put doSleep(5_000) before the assertion. The reason is that checkpoint deletes completed task t0 (see DurableBackgroundTasksProcessor#onMarkCheckpointBegin where we make it.remove()). So there is race condition between the assertion and checkpoint

I suggest updating statement to assert and providing clear message


assertTrue("Expected 3 tasks after restore, or 2 if completed converted task was already cleaned by checkpoint",
tasks == 2 || tasks == 3);

checkStateAndMetaStorage(n, t0, COMPLETED, true, true, false);
checkStateAndMetaStorage(n, t1, INIT, true, false, false);
Expand Down Expand Up @@ -535,7 +539,7 @@ private void checkStateAndMetaStorage(
if (expState == null)
assertNull(taskState);
else {
assertEquals(expState, taskState.state());
assertTrue(waitForCondition(() -> expState == taskState.state(), 1_000));
assertEquals(expSaved, taskState.saved());
assertEquals(expDone, taskState.outFuture().isDone());

Expand Down
Loading