Skip to content

IGNITE-28686 Improve .NET deployment test diagnostics #13144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ignitetcbot wants to merge 1 commit into
base: master
Choose a base branch
from
+16 −4
Open

IGNITE-28686 Improve .NET deployment test diagnostics #13144

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 16 additions & 4 deletions modules/platforms/dotnet/Apache.Ignite.Core.Tests/DeploymentTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,7 @@ private void TestDeployment(string dllFolder, string jarFolder, bool buildClassp
Assert.Fail("Node failed to start: " + string.Join("\n", reader.GetOutput()));
}

VerifyNodeStarted(exePath);
VerifyNodeStarted(exePath, proc, reader);
}

/// <summary>
Expand Down Expand Up @@ -227,21 +227,33 @@ private void DeployTo(string folder, string jarFolder = null)
/// <summary>
/// Verifies that custom-deployed node has started.
/// </summary>
private static void VerifyNodeStarted(string exePath)
private static void VerifyNodeStarted(string exePath, System.Diagnostics.Process proc, ListDataReader reader)
{
using (var ignite = Ignition.Start(new IgniteConfiguration(TestUtils.GetTestConfiguration())
{
SpringConfigUrl = "Config/Compute/compute-grid1.xml",
}))
{
Assert.IsTrue(ignite.WaitTopology(2));
Assert.IsTrue(ignite.WaitTopology(2, 90000), GetProcessDetails(proc, reader));

var remoteProcPath = ignite.GetCluster().ForRemotes().GetCompute().Call(new ProcessPathFunc());

Assert.AreEqual(exePath, remoteProcPath);
Assert.AreEqual(exePath, remoteProcPath, GetProcessDetails(proc, reader));
}
}

/// <summary>
/// Gets external node process details for assertion messages.
/// </summary>
private static string GetProcessDetails(System.Diagnostics.Process proc, ListDataReader reader)
{
var procInfo = proc.HasExited
? string.Format("exited, exitCode={0}", proc.ExitCode)
: "alive";

return "External node process is " + procInfo + ". Output: " + string.Join("\n", reader.GetOutput());
}

#pragma warning disable 649
/// <summary>
/// Function that returns process path.
Expand Down