Skip to content

Fix value and time chunk misalignment when rewriting with time deletion #17142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JackieTien97 merged 2 commits into from
Feb 3, 2026
Merged

Fix value and time chunk misalignment when rewriting with time deletion #17142

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b24941f
Fix value and time chunk misalignment when rewriting with time deletion
shuwenwei Feb 3, 2026
01854a8
fix
shuwenwei Feb 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
55 changes: 55 additions & 0 deletions .../org/apache/iotdb/db/storageengine/dataregion/compaction/CompactionDataTypeAlterTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,12 +19,16 @@

package org.apache.iotdb.db.storageengine.dataregion.compaction;

import org.apache.iotdb.commons.exception.IllegalPathException;
import org.apache.iotdb.commons.exception.MetadataException;
import org.apache.iotdb.commons.path.MeasurementPath;
import org.apache.iotdb.db.exception.StorageEngineException;
import org.apache.iotdb.db.storageengine.dataregion.compaction.execute.performer.impl.FastCompactionPerformer;
import org.apache.iotdb.db.storageengine.dataregion.compaction.execute.performer.impl.ReadChunkCompactionPerformer;
import org.apache.iotdb.db.storageengine.dataregion.compaction.execute.performer.impl.ReadPointCompactionPerformer;
import org.apache.iotdb.db.storageengine.dataregion.compaction.execute.task.InnerSpaceCompactionTask;
import org.apache.iotdb.db.storageengine.dataregion.modification.ModificationFile;
import org.apache.iotdb.db.storageengine.dataregion.modification.TreeDeletionEntry;
import org.apache.iotdb.db.storageengine.dataregion.tsfile.TsFileResource;
import org.apache.iotdb.db.storageengine.dataregion.tsfile.TsFileResourceStatus;
import org.apache.iotdb.db.storageengine.dataregion.utils.TsFileResourceUtils;
Expand Down Expand Up @@ -319,4 +323,55 @@ private void generateDataTypeNotMatchFilesWithAlignedSeries()
resource2.serialize();
seqResources.add(resource2);
}

@Test
public void testAlterDataTypeWithAlignedSeriesWithTimeDeletion()
throws IOException, WriteProcessException, IllegalPathException {
List<IMeasurementSchema> measurementSchemas1 = new ArrayList<>();
measurementSchemas1.add(new MeasurementSchema("s1", TSDataType.INT32));
measurementSchemas1.add(new MeasurementSchema("s2", TSDataType.INT32));

TsFileResource resource1 = createEmptyFileAndResource(true);
resource1.setStatusForTest(TsFileResourceStatus.COMPACTING);
try (TsFileWriter writer = new TsFileWriter(resource1.getTsFile())) {
writer.registerAlignedTimeseries(new Path(device), measurementSchemas1);
for (int i = 0; i < 100; i++) {
TSRecord record = new TSRecord(device, i);
record.addTuple(new IntDataPoint("s1", 0));
record.addTuple(new IntDataPoint("s2", 1));
writer.writeRecord(record);
}
writer.flush();
}
resource1.updateStartTime(device, 1);
resource1.updateEndTime(device, 1);
resource1.serialize();
ModificationFile modFile = resource1.getExclusiveModFile();
modFile.write(new TreeDeletionEntry(new MeasurementPath(device + ".*"), 0, 40));
modFile.close();
seqResources.add(resource1);

List<IMeasurementSchema> measurementSchemas2 = new ArrayList<>();
measurementSchemas2.add(new MeasurementSchema("s1", TSDataType.DOUBLE));
measurementSchemas2.add(new MeasurementSchema("s2", TSDataType.DOUBLE));
TsFileResource resource2 = createEmptyFileAndResource(true);
resource2.setStatusForTest(TsFileResourceStatus.COMPACTING);
try (TsFileWriter writer = new TsFileWriter(resource2.getTsFile())) {
writer.registerAlignedTimeseries(new Path(device), measurementSchemas2);
TSRecord record = new TSRecord(device, 200);
record.addTuple(new DoubleDataPoint("s1", 2.0));
record.addTuple(new DoubleDataPoint("s2", 3.0));
writer.writeRecord(record);
writer.flush();
}
resource2.updateStartTime(device, 2);
resource2.updateEndTime(device, 2);
resource2.serialize();
seqResources.add(resource2);

InnerSpaceCompactionTask task =
new InnerSpaceCompactionTask(
0, tsFileManager, seqResources, true, new ReadChunkCompactionPerformer(), 0);
Assert.assertTrue(task.start());
}
}
2 changes: 1 addition & 1 deletion pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,7 @@
<thrift.version>0.14.1</thrift.version>
<xz.version>1.9</xz.version>
<zstd-jni.version>1.5.6-3</zstd-jni.version>
<tsfile.version>2.2.1-260130-SNAPSHOT</tsfile.version>
<tsfile.version>2.2.1-260203-SNAPSHOT</tsfile.version>
</properties>
<!--
if we claim dependencies in dependencyManagement, then we do not claim
Expand Down
Loading