Skip to content

Conversation

@reschke
Copy link
Contributor

@reschke reschke commented Oct 1, 2025

No description provided.

@reschke reschke requested a review from kwin October 1, 2025 11:06
@reschke reschke self-assigned this Oct 1, 2025
Copy link
Member

@kwin kwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The idea was that the target-osgi-environment represents some real live distribution not something which one can arbitrarily increase. Please pick a recent AEMaaCS version which already comes with Collections 4.5 and also update all other bundles accordingly.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In line40 the comment must be changed (was wrong right from the beginning), it used to reflect the bundles provided by some AEMaaCS version.

<groupId>org.apache.commons</groupId>
<artifactId>commons-collections4</artifactId>
<version>4.4</version>
<version>4.5.0</version>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this necessary in this context? IMHO the max versions are never used to calculate import package version ranges....

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, indeed we are embedding the max versions of some JR2 artifacts even in the OSGi bundles. Should we rethink this? Currently those are

-conditionalpackage: org.apache.jackrabbit.jcr2spi.*
. I guess the runtime requirement for Collections 4.5 comes from that, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The requirement comes from the fact that otherwise ITs fails because they need 4.5.0.

@reschke
Copy link
Contributor Author

reschke commented Oct 2, 2025

See bb117c2

But with these changes, I now see:

[INFO] --- bnd-resolver-maven-plugin:6.4.0:resolve (default) @ org.apache.jackrabbit.vault.rcp ---
[INFO] Resolving C:\projects\apache\jackrabbit-filevault\vault-rcp\max-target.bndrun:
[INFO] Bnd inferred -runrequires: osgi.identity;filter:='(osgi.identity=org.apache.jackrabbit.vault.rcp)'
[ERROR] Resolution failed. Capabilities satisfying the following requirements could not be found:
    [<<INITIAL>>]
      ? osgi.identity: (osgi.identity=org.apache.jackrabbit.vault.rcp)
          ? [org.apache.jackrabbit.vault.rcp version=4.0.1.SNAPSHOT]
              ? osgi.wiring.package: (osgi.wiring.package=org.apache.http.impl.client)
                  ? [org.apache.httpcomponents.httpclient version=4.5.13]
                      ? osgi.wiring.package: (&(osgi.wiring.package=org.apache.commons.logging)(version>=1.1.0)(!(version>=1.3.0)))
                          ? [jcl.over.slf4j version=1.7.36]
                              ? osgi.wiring.package: (&(osgi.wiring.package=org.slf4j)(version>=1.7.36))
The following requirements are optional:
    [org.apache.httpcomponents.httpclient version=4.5.13]
      ? osgi.wiring.package: (osgi.wiring.package=net.spy.memcached)
      ? osgi.wiring.package: (osgi.wiring.package=net.sf.ehcache)
    [org.apache.sling.api version=2.27.6]
      ? osgi.wiring.package: (&(osgi.wiring.package=javax.jcr)(version>=2.0.0)(!(version>=3.0.0)))
    [org.apache.jackrabbit.vault version=4.0.1.SNAPSHOT]
      ? osgi.wiring.package: (&(osgi.wiring.package=org.apache.sling.jcr.api)(version>=2.0.0)(!(version>=3.0.0)))
      ? osgi.wiring.package: (osgi.wiring.package=org.apache.jackrabbit.spi2dav)
    [ch.qos.logback.core version=1.2.13]
      ? osgi.wiring.package: (osgi.wiring.package=org.codehaus.janino)
      ? osgi.wiring.package: (&(osgi.wiring.package=javax.servlet)(version>=3.1.0)(!(version>=4.0.0)))
      ? osgi.wiring.package: (osgi.wiring.package=org.codehaus.commons.compiler)
      ? osgi.wiring.package: (&(osgi.wiring.package=org.fusesource.jansi)(version>=1.9.0)(!(version>=2.0.0)))
      ? osgi.wiring.package: (osgi.wiring.package=javax.mail.internet)
      ? osgi.wiring.package: (&(osgi.wiring.package=javax.servlet.http)(version>=3.1.0)(!(version>=4.0.0)))
      ? osgi.wiring.package: (osgi.wiring.package=javax.mail)
    [ch.qos.logback.classic version=1.2.13]
      ? osgi.wiring.package: (&(osgi.wiring.package=javax.servlet)(version>=3.1.0)(!(version>=4.0.0)))
      ? osgi.wiring.package: (&(osgi.wiring.package=javax.servlet.http)(version>=3.1.0)(!(version>=4.0.0)))
    [org.apache.felix.configadmin version=1.9.24]
      ? osgi.wiring.package: (&(osgi.wiring.package=org.osgi.service.coordinator)(version>=1.0.0)(!(version>=2.0.0)))
      ? osgi.wiring.package: (&(osgi.wiring.package=org.osgi.service.log)(version>=1.3.0)(!(version>=2.0.0)))
      ? osgi.service: (objectClass=org.osgi.service.log.LogService)
    [org.apache.jackrabbit.jackrabbit-jcr-commons version=2.22.2]
      ? osgi.wiring.package: (&(osgi.wiring.package=org.apache.jackrabbit.api.security)(version>=2.4.0)(!(version>=3.0.0)))
      ? osgi.wiring.package: (&(osgi.wiring.package=org.apache.jackrabbit.api.security.principal)(version>=2.4.0)(!(version>=3.0.0)))
      ? osgi.wiring.package: (&(osgi.wiring.package=org.apache.jackrabbit.api.stats)(version>=1.2.0)(!(version>=2.0.0)))
      ? osgi.wiring.package: (&(osgi.wiring.package=org.apache.jackrabbit.api)(version>=2.8.0)(!(version>=3.0.0)))
      ? osgi.wiring.package: (&(osgi.wiring.package=org.apache.jackrabbit.api.observation)(version>=2.3.0)(!(version>=3.0.0)))
      ? osgi.wiring.package: (&(osgi.wiring.package=org.apache.jackrabbit.api.jmx)(version>=2.3.0)(!(version>=3.0.0)))
      ? osgi.wiring.package: (&(osgi.wiring.package=org.apache.jackrabbit.api.security.user)(version>=2.2.0)(!(version>=3.0.0)))
    [org.apache.felix.scr version=2.2.12]
      ? osgi.wiring.package: (&(osgi.wiring.package=org.osgi.service.metatype)(version>=1.2.0)(!(version>=2.0.0)))
      ? osgi.wiring.package: (&(osgi.wiring.package=org.apache.felix.service.command)(version>=1.0.0)(!(version>=2.0.0)))
      ? osgi.wiring.package: (&(osgi.wiring.package=org.osgi.service.cm)(version>=1.6.0)(!(version>=2.0.0)))
      ? osgi.wiring.package: (&(osgi.wiring.package=org.osgi.service.log)(version>=1.4.0)(!(version>=2.0.0)))
    [org.apache.commons.commons-io version=2.20.0]
      ? osgi.wiring.package: (osgi.wiring.package=sun.nio.ch)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants