-
Notifications
You must be signed in to change notification settings - Fork 72
JCRVLT-821: update max test versions to Oak 1.84.0 and Jackrabbit 2.22.2 #388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
kwin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The idea was that the target-osgi-environment represents some real live distribution not something which one can arbitrarily increase. Please pick a recent AEMaaCS version which already comes with Collections 4.5 and also update all other bundles accordingly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In line40 the comment must be changed (was wrong right from the beginning), it used to reflect the bundles provided by some AEMaaCS version.
| <groupId>org.apache.commons</groupId> | ||
| <artifactId>commons-collections4</artifactId> | ||
| <version>4.4</version> | ||
| <version>4.5.0</version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this necessary in this context? IMHO the max versions are never used to calculate import package version ranges....
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, indeed we are embedding the max versions of some JR2 artifacts even in the OSGi bundles. Should we rethink this? Currently those are
jackrabbit-filevault/vault-core/bnd.bnd
Line 20 in 4806680
| -conditionalpackage: org.apache.jackrabbit.jcr2spi.* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The requirement comes from the fact that otherwise ITs fails because they need 4.5.0.
|
See bb117c2 But with these changes, I now see: |
No description provided.