JCRVLT-830 incorrect aggregation can lead to deletion of content

[joerghoh]

I converted the case into a simple failing integration test:

[INFO] Running org.apache.jackrabbit.vault.packaging.integration.AggregationJCRVLT830IT
18:10:56.646 [main] INFO  o.a.j.o.j.session.SessionSaveDelayer - Initialized
18:10:56.676 [main] INFO  o.a.j.v.p.i.IntegrationTestBase - repository created: Apache Jackrabbit Oak 1.82.0
18:10:56.827 [main] INFO  o.a.j.v.packaging.impl.ActivityLog - filevault/test:JCRVLT-830:0.0.1: CREATE
18:10:56.828 [main] INFO  o.a.j.v.packaging.impl.ActivityLog - filevault/test:JCRVLT-830:0.0.1: UPLOAD
18:10:56.832 [main] INFO  o.a.j.v.p.i.IntegrationTestBase - Collecting import information...
18:10:56.835 [main] INFO  o.a.j.v.p.i.IntegrationTestBase - Installing node types...
18:10:56.836 [main] INFO  o.a.j.v.p.i.IntegrationTestBase - - rep -> internal
18:10:56.836 [main] INFO  o.a.j.v.p.i.IntegrationTestBase - - nt -> http://www.jcp.org/jcr/nt/1.0
18:10:56.836 [main] INFO  o.a.j.v.p.i.IntegrationTestBase - - cq -> http://www.day.com/jcr/cq/1.0
18:10:56.836 [main] INFO  o.a.j.v.p.i.IntegrationTestBase - - sling -> http://sling.apache.org/jcr/sling/1.0
18:10:56.836 [main] INFO  o.a.j.v.p.i.IntegrationTestBase - - sling:Folder
18:10:56.836 [main] INFO  o.a.j.v.p.i.IntegrationTestBase - - sling:OrderedFolder
18:10:56.836 [main] INFO  o.a.j.v.p.i.IntegrationTestBase - - rep:RepoAccessControllable
18:10:56.836 [main] INFO  o.a.j.v.p.i.IntegrationTestBase - Installing privileges...
18:10:56.836 [main] INFO  o.a.j.v.p.i.IntegrationTestBase - Importing content...
18:10:56.846 [main] INFO  o.a.j.v.p.i.IntegrationTestBase - - /
18:10:56.848 [main] INFO  o.a.j.v.p.i.IntegrationTestBase - - /content
18:10:56.850 [main] INFO  o.a.j.v.p.i.IntegrationTestBase - - /content/dam
18:10:56.851 [main] INFO  o.a.j.v.p.i.IntegrationTestBase - - /content/dam/qcom
18:10:56.853 [main] INFO  o.a.j.v.p.i.IntegrationTestBase - - /content/dam/qcom/content-fragments
18:10:56.853 [main] INFO  o.a.j.v.p.i.IntegrationTestBase - D /content/dam/qcom/content-fragments/en/test1
18:10:56.866 [main] INFO  o.a.j.v.p.i.IntegrationTestBase - A /content/dam/qcom/content-fragments/en/test1
18:10:56.868 [main] INFO  o.a.j.v.p.i.IntegrationTestBase - A /content/dam/qcom/content-fragments/en/test1/jcr:content
18:10:56.869 [main] INFO  o.a.j.v.p.i.IntegrationTestBase - saving approx 3 nodes...
18:10:56.870 [main] INFO  o.a.j.v.p.i.IntegrationTestBase - Package imported.
18:10:56.871 [main] INFO  o.a.j.v.packaging.impl.ActivityLog - filevault/test:JCRVLT-830:0.0.1: EXTRACT
[ERROR] Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.646 s <<< FAILURE! -- in org.apache.jackrabbit.vault.packaging.integration.AggregationJCRVLT830IT
[ERROR] org.apache.jackrabbit.vault.packaging.integration.AggregationJCRVLT830IT.installPackage -- Time elapsed: 0.197 s <<< FAILURE!
java.lang.AssertionError: /content/dam/qcom/content-fragments/en/test1/abc should exist
	at org.junit.Assert.fail(Assert.java:89)
	at org.junit.Assert.assertTrue(Assert.java:42)
	at org.apache.jackrabbit.vault.packaging.integration.IntegrationTestBase.assertNodeExists(IntegrationTestBase.java:502)
	at org.apache.jackrabbit.vault.packaging.integration.AggregationJCRVLT830IT.installPackage(AggregationJCRVLT830IT.java:91)

The test adds an additional node at /content/dam/qcom/content-fragments/en/test1/abc, which is deleted in this case, but which should not get deleted.

[joerghoh]

@kwin can you have a look here?