OAK-11672 log warnings when fetching large result sets #2390
Conversation
Commit-Check ✔️ |
|
thomasmueller
left a comment
thomasmueller
left a comment
There was a problem hiding this comment.
This is more a question:
We already log warnings if a query reads many nodes. What is different is:
- (A) in the current code (without the PR), warnings are logged when reading many entries from the index / from the node store
- (B) in this PR, warnings are logged while iterating over the results
It is possible that we see warnings from (A) but not from (B) for queries that don't have a proper index. Additionally, if many of the results are not accessible (missing access rights). Also, if a query has unindexed "order by" and only the first few entries are read.
So, I wonder, were you aware that we already log warnings in (A)? If yes, I do not see this information in the Jira issue. It would be good to add. Or maybe it is not working?
Then, having two kinds of warnings might possibly be a bit confusing? For me it's OK.
oak-jcr/src/main/java/org/apache/jackrabbit/oak/jcr/query/QueryResultDebugIterator.java
Outdated
Show resolved
Hide resolved
oak-jcr/src/main/java/org/apache/jackrabbit/oak/jcr/query/QueryResultDebugIterator.java
Outdated
Show resolved
Hide resolved
|
@thomasmueller I am aware of the warnings, when many nodes are read during a query (for whatever reason); these warnings are useful, as they indicate a slowness, but just from looking at them it's normally unclear why that many nodes are read. This PR adds logs for one of those cases (reading many results). |
…yResultDebugIterator.java PR feedback Co-authored-by: Thomas Mueller <thomasm@apache.org>
|
3 participants
No description provided.