OAK-12017: Add path information to CommitFailedException in EditorDiff #2635
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cschneider
commented
Nov 30, 2025
cschneider
commented
- Track current path during tree traversal in EditorDiff
- Automatically enhance CommitFailedException with path information
- Works generically for all editors, not just VersionEditor
- Path is appended to exception message: 'message (path: /path/to/node)'
- Avoids duplication if path already present in exception message
- Track current path during tree traversal in EditorDiff - Automatically enhance CommitFailedException with path information - Works generically for all editors, not just VersionEditor - Path is appended to exception message: 'message (path: /path/to/node)' - Avoids duplication if path already present in exception message
rishabhdaim
reviewed
Dec 1, 2025
Contributor
rishabhdaim
left a comment
rishabhdaim
left a comment
There was a problem hiding this comment.
Could you please create a unit case for this change.
Author
|
@rishabhdaim This is not yet at the level to be merged. I would like to first get feedback from Oak committers if this is a good idea and will work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.