Skip to content

Conversation

@smiroslav
Copy link
Contributor

@smiroslav smiroslav commented Dec 16, 2025

@ierandra
Copy link
Contributor

I think the fix should also be added to V8 implementation.

@smiroslav
Copy link
Contributor Author

I have changed the test to cause TimeoutException instead of mocking it.

@smiroslav
Copy link
Contributor Author

I think the fix should also be added to V8 implementation.

@ierandra will address it in a separate PR

@smiroslav
Copy link
Contributor Author

smiroslav commented Dec 18, 2025

I decided not to update reactor-core, as the Azure documentation advises against using a version with a different major or minor version than the one specified in the Azure SDK dependencies.
Azure SDK v12 version should be updated, but I would not do that in this PR.

https://learn.microsoft.com/en-us/azure/developer/java/sdk/troubleshooting-dependency-version-conflict#understand-compatible-dependency-versions
https://github.com/reactor/.github/blob/main/SUPPORT.adoc#our-policy-on-deprecations

Instead, IllegalStateException is treated as recoverable.

@smiroslav
Copy link
Contributor Author

I think the fix should also be added to V8 implementation.

@ierandra will address it in a separate PR

The AzureRepositoryLockV8 is already correctly handling client-side timeout exceptions in the correct way:
#2667

@ierandra
Copy link
Contributor

@smiroslav

The AzureRepositoryLockV8 is already correctly handling client-side timeout exceptions in the correct way:

that is very strange because when we did the analysis we observe the same issue for customers running on v8

@smiroslav
Copy link
Contributor Author

@ierandra, looking at the code, all exceptions that happen in AzureRepositoryLockV8#refreshLease should be logged.

Do you perhaps have the stacktrace?

I suggest we move the discussion for v8 to the JIRA or #2667.

@jsedding
Copy link
Contributor

jsedding commented Dec 19, 2025

I decided not to update reactor-core ...

I hope you're still merging the rest of the PR, because eventually we will update azure and reactor 🙂

@smiroslav smiroslav merged commit e4a2b39 into apache:trunk Dec 19, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants