Skip to content

OAK-12047 - CachingSegmentArchiveReader#readSegment should check if archive contains segment before looking up in the PersistentCache #2672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nfsantos wants to merge 1 commit into
base: trunk
Choose a base branch
from
Open

OAK-12047 - CachingSegmentArchiveReader#readSegment should check if archive contains segment before looking up in the PersistentCache #2672

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion ...e/jackrabbit/oak/segment/spi/persistence/persistentcache/CachingSegmentArchiveReader.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,11 @@ public CachingSegmentArchiveReader(
@Override
@Nullable
public Buffer readSegment(long msb, long lsb) throws IOException {
return persistentCache.readSegment(msb, lsb, () -> delegate.readSegment(msb, lsb));
if (delegate.containsSegment(msb, lsb)) {
return persistentCache.readSegment(msb, lsb, () -> delegate.readSegment(msb, lsb));
} else {
return null;
}
}

@Override
Expand Down
Loading