KAFKA-19740: Deprecate group.coordinator.rebalance.protocols config (KIP-1237)#21522
Merged
chia7712 merged 12 commits intoapache:trunkfrom Mar 10, 2026
Merged
Conversation
…KIP-1237) Mark the group.coordinator.rebalance.protocols configuration as deprecated for removal in Kafka 5.0. When users set a value that disables any default protocol, a warning is logged advising them to restore the default or remove the configuration. The share protocol no-op warning is also preserved.
Member
Member
@mingyen066 please fix the build warnings |
…OR_REBALANCE_PROTOCOLS_CONFIG
Contributor
squah-confluent
left a comment
There was a problem hiding this comment.
Thanks for the patch!
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorConfig.java
Show resolved
Hide resolved
tools/src/test/java/org/apache/kafka/tools/streams/DescribeStreamsGroupTest.java
Outdated
Show resolved
Hide resolved
Member
|
@mingyen066 please fix the conflicts |
chia7712
reviewed
Mar 2, 2026
tools/src/test/java/org/apache/kafka/tools/streams/ListStreamsGroupTest.java
Outdated
Show resolved
Hide resolved
tools/src/test/java/org/apache/kafka/tools/streams/DescribeStreamsGroupTest.java
Outdated
Show resolved
Hide resolved
Member
|
@mingyen066 please cleanup the following files as well |
chia7712
reviewed
Mar 5, 2026
...ration-tests/src/test/java/org/apache/kafka/clients/consumer/ShareConsumerRackAwareTest.java
Outdated
Show resolved
Hide resolved
Member
|
|
chia7712
reviewed
Mar 6, 2026
…ferentiate deprecation warnings
9539bc2 to
13397fd
Compare
Collaborator
Author
|
Sorry for the accidental force push, no change, just to re-trigger CI. |
chia7712
reviewed
Mar 9, 2026
tools/src/test/java/org/apache/kafka/tools/GroupsCommandTest.java
Outdated
Show resolved
Hide resolved
chia7712
approved these changes
Mar 10, 2026
Member
|
Ugh, looks like there's still one test using classic,consumer,streams we'll file a minor patch |
Collaborator
|
The fix patch #21699 |
frankvicky
pushed a commit
that referenced
this pull request
Mar 11, 2026
#21699) Cleanup test which using `classic,consumer,streams`, see comment #21522 (comment) Reviewers: TengYao Chi <frankvicky@apache.org>, Lan Ding <isDing_L@163.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement KIP-1237.
group.coordinator.rebalance.protocolsconfigurationfor removal in Kafka 5.0.
(classic, consumer, streams), advising them to remove the configuration
doLogto avoid duplicate output during startupgroup.coordinator.rebalance.protocolssettings intest files —
"classic,consumer,streams"is already the default, andshareis a no-op (controlled byshare.versionfeature)Test result:
Reviewers: Sean Quah squah@confluent.io, Chia-Ping Tsai
chia7712@gmail.com