KAFKA-13630: Reduce deque lock scope in RecordAccumulator.drainBatchesForOneNode#21665
Open
nileshkumar3 wants to merge 1 commit intoapache:trunkfrom
Open
KAFKA-13630: Reduce deque lock scope in RecordAccumulator.drainBatchesForOneNode#21665nileshkumar3 wants to merge 1 commit intoapache:trunkfrom
nileshkumar3 wants to merge 1 commit intoapache:trunkfrom
Conversation
…ordAccumulator.java
github-actions
bot
added
triage
Author
|
@jasonk000 Can you review this |
Author
|
@showuon can you please approve this. |
Contributor
|
I'm not a kafka committer nor familiar with this code anymore (it seems to have changed a lot since my last change to this code in 2022). thx. |
Author
|
@lucasbru Can you please review this |
Author
|
@yuyang08 Can you please review this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR reduces lock hold time in RecordAccumulator.drainBatchesForOneNode by moving transactional producer state updates outside the synchronized deque block after the batch is removed.
The change keeps only deque-dependent checks and pollFirst() under the lock, which helps reduce producer-side contention without changing the existing drain logic.