KAFKA-20077: Prevent infinite AddPartitionsToTxn retries causing producer.flush() to hang#21672
Open
nileshkumar3 wants to merge 1 commit intoapache:trunkfrom
Open
KAFKA-20077: Prevent infinite AddPartitionsToTxn retries causing producer.flush() to hang#21672nileshkumar3 wants to merge 1 commit intoapache:trunkfrom
nileshkumar3 wants to merge 1 commit intoapache:trunkfrom
Conversation
…ucer.flush() to hang
github-actions
bot
added
triage
Author
|
@lianetm Can you please review this |
Author
|
@lucasbru Can you please review this |
Author
|
@hachikuji Can you please review this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root Cause
The AddPartitionsToTxn handler may repeatedly re-enqueue itself on
retriable errors without any client-side timeout bounding the retry loop.
If the topic is deleted during this phase, the client may never make
progress and producer.flush() may block indefinitely.
Fix
Track the first retriable error timestamp and fail the request if
retries exceed transaction.timeout.ms.