KAFKA-19752 Move parts of UnifiedLogTest to storage module#21686
Open
m1a2st wants to merge 6 commits intoapache:trunkfrom
Open
KAFKA-19752 Move parts of UnifiedLogTest to storage module#21686m1a2st wants to merge 6 commits intoapache:trunkfrom
m1a2st wants to merge 6 commits intoapache:trunkfrom
Conversation
github-actions
bot
added
core
mimaison
reviewed
Mar 10, 2026
Member
mimaison
left a comment
mimaison
left a comment
There was a problem hiding this comment.
Thanks for the PR, I left a few comments
|
|
||
| @Test | ||
| public void testReadWithMinMessage() throws IOException { | ||
| var logConfig = new LogTestUtils.LogConfigBuilder() |
Member
There was a problem hiding this comment.
We don't use var anywhere else in this file or even module. So maybe keep the types for consistency.
|
|
||
| @Test | ||
| public void testRandomRecords() throws IOException { | ||
| var random = new java.util.Random(); |
Comment on lines
-55
to
-57
| import net.jqwik.api.AfterFailureMode | ||
| import net.jqwik.api.ForAll | ||
| import net.jqwik.api.Property |
Member
There was a problem hiding this comment.
I don't think we use net.jqwik anywhere else in core. Can we remove testImplementation libs.jqwik from build.gradle?
| assertEquals(expected, offsetResultHolder.futureHolderOpt().get().taskFuture().get().timestampAndOffset().orElse(null)); | ||
| } | ||
|
|
||
| private KafkaConfig createKafkaConfigWithRLM() { |
Member
There was a problem hiding this comment.
Could we get rid this method? It seems all the tests only require a broker id and an instance of RemoteLogManagerConfig
My thinking is that this would remove the dependency on KafkaConfig
Collaborator
Author
|
Thanks for @mimaison review, addressed all comments |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From
testReadWithMinMessagetotestFetchLatestTieredTimestampWithRemoteStorage