MINOR: Migrate NodeToControllerRequestThreadTest from Scala to Java#21693
Merged
FrankYang0529 merged 2 commits intoapache:trunkfrom Mar 11, 2026
Merged
MINOR: Migrate NodeToControllerRequestThreadTest from Scala to Java#21693FrankYang0529 merged 2 commits intoapache:trunkfrom
FrankYang0529 merged 2 commits intoapache:trunkfrom
Conversation
github-actions
bot
added
triage
Move NodeToControllerRequestThreadTest from core (kafka.server) to the server module (org.apache.kafka.server) and rewrite in Java. Use real Supplier implementations instead of mocking to avoid unchecked cast warnings from generic type erasure. Remove the now-unused TestControllerRequestCompletionHandler from TestUtils.scala.
DL1231
force-pushed
the
MINOR_migrate_nodeTest
branch
from
425fcce to
1bf8767
Compare
server/src/test/java/org/apache/kafka/server/NodeToControllerRequestThreadTest.java
Show resolved
Hide resolved
FrankYang0529
approved these changes
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move
NodeToControllerRequestThreadTestfrom core to the server moduleand rewrite in Java.
Reviewers: PoAn Yang payang@apache.org