KAFKA-20134: Fix header-based key deserialization in MeteredTimestampedWindowStoreWithHeaders iterator methods#21705
Open
frankvicky wants to merge 2 commits intoapache:trunkfrom
Open
Conversation
…WithHeaders iterator methods
frankvicky
changed the title
mjsax
added
kip
mjsax
changed the title
mjsax
requested changes
Mar 10, 2026
|
|
||
| @Override | ||
| public KeyValue<Windowed<K>, ValueTimestampHeaders<V>> next() { | ||
| final KeyValue<Windowed<Bytes>, byte[]> next = iter.next(); |
Member
There was a problem hiding this comment.
I think we need null check for next ?
| @Override | ||
| public Windowed<K> peekNextKey() { | ||
| final Windowed<Bytes> bytesKey = iter.peekNextKey(); | ||
| final K key = serdes.keyFrom(bytesKey.key().get(), new RecordHeaders()); |
Member
There was a problem hiding this comment.
Seems this needs to get updated? We also need to pass in headers here into keyFrom (not just empty headers)? So we need to deserialize the valueTimestampeHeader byte array to parse out the headers.
Not 100% sure what the best way to do this will be... Maybe we cannot call iter.peekNextKey() but need to call iter.next(), and remember that we did this, for the next next() call to not step over a record incorrectly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a bug where
MeteredTimestampedWindowStoreWithHeadersiteratormethods fail when key deserializers require headers.
The class inherits iterator-returning methods from
MeteredWindowStore:fetchAll(long, long)/backwardFetchAll(long, long)-all()/backwardAll()-fetch(K, K, long, long)/backwardFetch(K, K, long, long)These methods use the deprecated
serdes::keyFrom(rawKey)whichprovides empty headers, causing deserialization failures when headers
are required.