Simplify SortedProperties.entrySet()#2629
Open
rovarga wants to merge 1 commit intoapache:mainfrom
Open
Conversation
Use Comparator.comparing() and Collectors.toCollection() to make the method much more obvious. Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
There was a problem hiding this comment.
Pull request overview
This PR simplifies SortedProperties.entrySet() to make the sorting logic clearer by using Comparator.comparing(...) and collecting directly into a LinkedHashSet, keeping the returned iteration order sorted by key string.
Changes:
- Replaced the custom comparator + iterator loop with a stream pipeline using
Comparator.comparing(...). - Collected the sorted entries via
Collectors.toCollection(LinkedHashSet::new). - Removed the now-unused
Iteratorimport and addedCollectors.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+43
to
+45
| return super.entrySet().stream() | ||
| .sorted(Comparator.comparing(entry -> entry.getKey().toString())) | ||
| .collect(Collectors.toCollection(LinkedHashSet::new)); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use Comparator.comparing() and Collectors.toCollection() to make the
method much more obvious.
Signed-off-by: Robert Varga robert.varga@pantheon.tech