KNOX-3039 - Add error message sanitization to GatewayServlet #1062
+331
−12
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
❗❗❗IMPORTANT❗❗❗
This PR is an almost identical copy of #914 (including this description), except:
SanitizedExceptionstill complies with the Single Responsibility principal, but sanitization is centralized and reusable.What changes were proposed in this pull request?
This pull request introduces a mechanism to sanitize error messages in the
GatewayServletto improve security by hiding IP addresses from exception messages. The following changes were made:isErrorMessageSanitizationEnabledflag to theGatewayServletto control whether error messages should be sanitized.sanitizeExceptionandsanitizeAndRethrowmethods inGatewayServletto handle exception sanitization.GatewayConfiginterface and its implementationGatewayConfigImplto include a new methodisErrorMessageSanitizationEnabled.GatewayServletTestclass to parameterize tests for scenarios where sanitization is enabled and disabled.How was this patch tested?
This patch was tested using the following methods:
GatewayServletTestto cover both scenarios where error message sanitization is enabled and disabled.Test steps:
GatewayServletTestto check for sanitized and non-sanitized error messages.