Skipping scorer construction for clauses with zero cost#15998
Open
sgup432 wants to merge 5 commits into
Open
Conversation
github-actions
Bot
added
module:core/store
module:analysis
module:core/index
module:demo
module:highlighter
module:benchmark
module:suggest
module:spatial
module:luke
module:core/codecs
module:facet
module:grouping
module:queryparser
module:join
module:classification
module:spatial3d
module:queries
module:monitor
module:build-infra
labels
sgup432
force-pushed
the
skip_zero_cost_construction
branch
from
3f4c393 to
5f94d7d
Compare
github-actions
Bot
removed
module:demo
module:highlighter
module:benchmark
module:suggest
module:spatial
module:luke
module:core/codecs
module:facet
module:grouping
module:queryparser
module:join
module:classification
module:spatial3d
module:queries
module:monitor
module:build-infra
labels
Contributor
Author
|
@msfroh mind taking this a look? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Refer - #15887 for details
This skips the scorer construction for clauses with zero cost. As with the example given in above issue, if a user sends hundred of should clauses, and with most of them or ALL with zero cost, we still end up constructing the scorer leading to unnecessary CPU cycles consumption.