Fix(15831): Resolve race condition in ReferenceManager.doMaybeRefresh#16032
Closed
vijaykriishna wants to merge 0 commit into
Closed
Fix(15831): Resolve race condition in ReferenceManager.doMaybeRefresh#16032vijaykriishna wants to merge 0 commit into
vijaykriishna wants to merge 0 commit into
Conversation
vijaykriishna
force-pushed
the
fix/15831-10_x
branch
from
b17ec38 to
fe6c7f6
Compare
vijaykriishna
force-pushed
the
fix/15831-10_x
branch
from
fe6c7f6 to
b1e3445
Compare
vijaykriishna
force-pushed
the
fix/15831-10_x
branch
from
b1e3445 to
7753e71
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The key behavioural change is that with the loop in doMaybeRefresh(), a single call to maybeRefreshBlocking() will now refresh through multiple generations until the reference is fully up to date. This ensures that pending refreshes are not lost due to timing races.
Resolves #15831
Please note the fix is aimed to target 10.5.0 release/version.